maropu commented on a change in pull request #30560:
URL: https://github.com/apache/spark/pull/30560#discussion_r533443749
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
##########
@@ -394,7 +394,7 @@ trait GetMapValueUtil extends BinaryExpression with
ImplicitCastInputTypes {
val keyJavaType = CodeGenerator.javaType(keyType)
nullSafeCodeGen(ctx, ev, (eval1, eval2) => {
val keyNotFoundBranch = if (failOnError) {
- s"""throw new NoSuchElementException("Key " + $eval2 + " does not
exist.");"""
+ s"""throw new java.util.NoSuchElementException("Key " + $eval2 + "
does not exist.");"""
Review comment:
> And as i investigated, there are some cases would fail if I correct
the behavior of checkExceptionInExpression by using withSQLConf set
CodeGenFallBack to false, like ObjectExpressionsSuite and
RegexpExpressionsSuite and etc.
How about making a PR to fix `checkExceptionInExpression` first? I'm not
sure how many failures caused by it exist now. If there are too many failures,
we can separate the work to fix them then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
