tgravescs commented on a change in pull request #30504:
URL: https://github.com/apache/spark/pull/30504#discussion_r533514274
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -48,6 +48,9 @@ object ConstantFolding extends Rule[LogicalPlan] {
// object and running eval unnecessarily.
case l: Literal => l
+ case Size(c: CreateArray, _) => Literal(c.children.length)
+ case Size(c: CreateMap, _) => Literal(c.children.length / 2)
Review comment:
so the problem with this is it doesn't work with nested.. like inline
with array of struct:
f(CreateArray(Seq(CreateStruct(Seq('c1)))))
Unless we want to recurse down. I don't think there is any one type we can
use for the complex type generators though, thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
