Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4990#discussion_r28475528
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/ExternalShuffleService.scala ---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.shuffle
+
+import org.apache.spark.SparkConf
+import org.apache.spark.SecurityManager
+import org.apache.spark.network.netty.SparkTransportConf
+import org.apache.spark.network.shuffle.ExternalShuffleBlockHandler
+import org.apache.spark.network.TransportContext
+import org.apache.spark.network.sasl.SaslRpcHandler
+import org.apache.spark.network.server.TransportServer
+import org.apache.spark.Logging
+import org.apache.spark.util.Utils
+import sun.misc.Signal
+import sun.misc.SignalHandler
+import java.util.concurrent.CountDownLatch
+
+/**
+ * A main class for runing the external shuffle service. This follows
+ * closely how
[[org.apache.spark.deploy.worker.StandaloneWorkerShuffleService]] works.
+ *
+ * @note This adds handlers for SIGINT and SIGTERM to terminate gracefully.
+ */
+object ExternalShuffleService extends Logging {
+ @volatile
+ private var server: TransportServer = _
+
+ private val barrier = new CountDownLatch(1)
+
+ def main(args: Array[String]): Unit = {
--- End diff --
This whole method kind of duplicates the code in
`StandaloneWorkerShuffleService`. If you look at that class, you'll find that
there's actually nothing specific to standalone mode there. So I would suggest
that we simply rename that class to `ExternalShuffleService` and add a main
method there that just instantiates an instance of the service and blocks until
the process exits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
