Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4990#issuecomment-93605363
@dragos The changes look fine. I left a suggestion on the placement of
functionality that I believe will make this service more general and at the
same time reduce the amount of duplicate code. In terms of documentation, I
would leave it out of this patch since we still need to document the existence
of the shuffle service in the first place! (That is, outside the context of
dynamic allocation)
Another thing is that the scope of this patch is actually outside of Mesos,
so I would just remove references to that in the title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
