gengliangwang commented on a change in pull request #30573:
URL: https://github.com/apache/spark/pull/30573#discussion_r535901485
##########
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##########
@@ -386,7 +386,7 @@ private class LiveExecutorStageSummary(
metrics.memoryBytesSpilled,
metrics.diskBytesSpilled,
isExcluded,
- Some(peakExecutorMetrics).filter(_.isSet),
+ Some(peakExecutorMetrics),
Review comment:
I think it's better to resolve in the read side. Otherwise, there is no
need to make this field optional as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
