AngersZhuuuu commented on a change in pull request #30573:
URL: https://github.com/apache/spark/pull/30573#discussion_r535908529
##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -243,23 +243,39 @@ function createRowMetadataForColumn(colKey, data,
checkboxId) {
}
function reselectCheckboxesBasedOnTaskTableState() {
- var allChecked = true;
- var taskSummaryMetricsTableCurrentFilteredArray =
taskSummaryMetricsTableCurrentStateArray.slice();
- if (typeof taskTableSelector !== 'undefined' &&
taskSummaryMetricsTableCurrentStateArray.length > 0) {
- for (var k = 0; k < optionalColumns.length; k++) {
- if (taskTableSelector.column(optionalColumns[k]).visible()) {
- $("#box-"+optionalColumns[k]).prop('checked', true);
-
taskSummaryMetricsTableCurrentStateArray.push(taskSummaryMetricsTableArray.filter(row
=> (row.checkboxId).toString() == optionalColumns[k])[0]);
- taskSummaryMetricsTableCurrentFilteredArray =
taskSummaryMetricsTableCurrentStateArray.slice();
- } else {
- allChecked = false;
- }
- }
- if (allChecked) {
- $("#box-0").prop('checked', true);
- }
-
createDataTableForTaskSummaryMetricsTable(taskSummaryMetricsTableCurrentFilteredArray);
- }
+ var taskSummaryHasSelected = false;
+ var executorSummaryHasSelected = false;
+ var allTaskSummaryChecked = true;
+ var allExecutorSummaryChecked = true;
+ var taskSummaryMetricsTableCurrentFilteredArray =
taskSummaryMetricsTableCurrentStateArray.slice();
+ if (typeof taskTableSelector !== 'undefined' &&
taskSummaryMetricsTableCurrentStateArray.length > 0) {
Review comment:
change back, some indent in this js file is wrong， got me wrong too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
