gengliangwang commented on a change in pull request #30573:
URL: https://github.com/apache/spark/pull/30573#discussion_r535954000
##########
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##########
@@ -386,7 +386,7 @@ private class LiveExecutorStageSummary(
metrics.memoryBytesSpilled,
metrics.diskBytesSpilled,
isExcluded,
- Some(peakExecutorMetrics).filter(_.isSet),
+ Some(peakExecutorMetrics),
Review comment:
The code was introduce in https://github.com/apache/spark/pull/29020.
I want to make sure the API is reasonable instead of being safest.
##########
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##########
@@ -386,7 +386,7 @@ private class LiveExecutorStageSummary(
metrics.memoryBytesSpilled,
metrics.diskBytesSpilled,
isExcluded,
- Some(peakExecutorMetrics).filter(_.isSet),
+ Some(peakExecutorMetrics),
Review comment:
The code was introduced in https://github.com/apache/spark/pull/29020.
I want to make sure the API is reasonable instead of being safest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
