sarutak commented on a change in pull request #30573:
URL: https://github.com/apache/spark/pull/30573#discussion_r535993346
##########
File path: core/src/main/scala/org/apache/spark/status/api/v1/api.scala
##########
@@ -86,7 +86,7 @@ class ExecutorStageSummary private[spark](
val isBlacklistedForStage: Boolean,
@JsonSerialize(using = classOf[ExecutorMetricsJsonSerializer])
@JsonDeserialize(using = classOf[ExecutorMetricsJsonDeserializer])
- val peakMemoryMetrics: Option[ExecutorMetrics],
+ val peakMemoryMetrics: ExecutorMetrics,
Review comment:
How about checking whether `row` has `peakMemoryMetrics` in
`stagepages.js` rather than changing the API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]