AngersZhuuuu commented on a change in pull request #30573:
URL: https://github.com/apache/spark/pull/30573#discussion_r535991231
##########
File path:
core/src/test/resources/HistoryServerExpectations/excludeOnFailure_for_stage_expectation.json
##########
@@ -698,6 +698,28 @@
"memoryBytesSpilled" : 0,
"diskBytesSpilled" : 0,
"isBlacklistedForStage" : true,
+ "peakMemoryMetrics" : {
+ "JVMHeapMemory" : -1,
Review comment:
> The `-1` here is wrong. It is set to -1 on purpose.
>
> ```
> class ExecutorMetrics private[spark] extends Serializable {
> // Metrics are indexed by ExecutorMetricType.metricToOffset
> private val metrics = new Array[Long](ExecutorMetricType.numMetrics)
> // the first element is initialized to -1, indicating that the values
for the array
> // haven't been set yet.
> metrics(0) = -1
> ```
This is a tricky question, we'd better change a method to judge whether is
it set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
