linhongliu-db commented on a change in pull request #30662:
URL: https://github.com/apache/spark/pull/30662#discussion_r539805347
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -114,7 +114,8 @@ case class AnalysisContext(
nestedViewDepth: Int = 0,
maxNestedViewDepth: Int = -1,
relationCache: mutable.Map[Seq[String], LogicalPlan] = mutable.Map.empty,
- referredTempViewNames: Seq[Seq[String]] = Seq.empty)
+ referredTempViewNames: Seq[Seq[String]] = Seq.empty,
+ isTempView: Boolean = false)
Review comment:
you are correct in the first comment. we can just use
`referredTempFunctionNames`. But this approach will fix both permanent and temp
view problems, which I was planning to fix them separately. Anyway, I switch to
use `referredTempFunctionNames` in the latest commit.
BTW, in 3.0/2.4, temp view stores analyzed plan, and won't be wrapped in
`View`, so we don't need the `isTempView` flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
