maropu commented on a change in pull request #30713:
URL: https://github.com/apache/spark/pull/30713#discussion_r540679541



##########
File path: docs/monitoring.md
##########
@@ -1038,6 +1038,22 @@ This example shows a list of Spark configuration 
parameters for a Graphite sink:
 "spark.metrics.conf.*.sink.graphite.prefix"="optional_prefix"
 
"spark.metrics.conf.*.sink.graphite.regex"="optional_regex_to_send_matching_metrics"
 ```
+Also it could be done under spark session like:
+```
+import org.apache.spark.sql.SparkSession

Review comment:
       Why we need this example? You think it is difficult for users to know 
how to pass these parameter into Spark?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to