Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5548#discussion_r28582541
--- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala ---
@@ -245,7 +245,7 @@ class ContextCleanerSuite extends
ContextCleanerSuiteBase {
assert(fs.exists(RDDCheckpointData.rddCheckpointDataPath(sc,
rddId).get))
// Test that GC causes checkpoint data cleanup after dereferencing the
RDD
- postGCTester = new CleanerTester(sc, Seq(rddId), Nil, Nil)
+ postGCTester = new CleanerTester(sc, Seq(rddId), Nil, Nil, Seq(rddId))
--- End diff --
How does this fix the assertion that failed? you add a new set of IDs that
must now be counted down by a new callback, and you assert it ends up empty,
which is good. But the assertion that failed was earlier:
```
assert(fs.exists(RDDCheckpointData.rddCheckpointDataPath(sc,
rddId).get))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
