Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5548#discussion_r28586982
--- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala ---
@@ -427,12 +429,17 @@ class CleanerTester(
def broadcastCleaned(broadcastId: Long): Unit = {
toBeCleanedBroadcstIds -= broadcastId
- logInfo("Broadcast" + broadcastId + " cleaned")
+ logInfo("Broadcast " + broadcastId + " cleaned")
}
def accumCleaned(accId: Long): Unit = {
logInfo("Cleaned accId " + accId + " cleaned")
}
+
+ def checkpointCleaned(rddId: Long): Unit = {
+ toBeCheckpointIds -= rddId
--- End diff --
Great, that's a good explanation. I see that this makes it effectively wait
longer to proceed, by which time some necessary conditions are true, like that
checkpoint cleanup has happened. Thank you for that detail, and to the limits
of my knowledge, this looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
