HeartSaVioR edited a comment on pull request #30814: URL: https://github.com/apache/spark/pull/30814#issuecomment-747183380
This sounds me as we have to separate the public API and the others in CORE module as well. The class is not designed to be a public class, and even in Spark codebase, it's instantiated via `EventLogFileReader.apply`. (Same applied to `RollingEventLogFilesFileReader`) IMHO the root cause is that these classes are not properly scoped (at least applying package private). My bad. Not sure about the future approach. Once we exposed these classes should we expose them forever as public API? Or should we agree about the mistake and hide them ASAP? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
