HeartSaVioR commented on pull request #30814: URL: https://github.com/apache/spark/pull/30814#issuecomment-747188972
Downstream wouldn't be easy to leverage the class in any way because the entire interface is not designed to plug in. Once downstream extends the class and tries to replace with their custom one to change the behavior of SHS, they should probably extend another SHS part of code to not use `EventLogFileReader.apply`, cause it only provides either SingleFileEventLogFileReader or RollingEventLogFilesFileReader, not custom one. Given the complexity, only few downstream may try it, and that fits on the purpose of "developer APIs" which doesn't guarantee backward compatibility. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
