HyukjinKwon commented on a change in pull request #30663:
URL: https://github.com/apache/spark/pull/30663#discussion_r546661583
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
##########
@@ -270,7 +270,7 @@ class ParquetFileFormat
lazy val footerFileMetaData =
ParquetFileReader.readFooter(sharedConf, filePath,
SKIP_ROW_GROUPS).getFileMetaData
// Try to push down filters when filter push-down is enabled.
- val pushed = if (enableParquetFilterPushDown) {
+ val pushed = if (enableParquetFilterPushDown && filters.nonEmpty) {
Review comment:
BTW, I don't think we save touching footer in this case because it will
be read anyway later `footerFileMetaData`. But logically seems fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
