Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/5547#issuecomment-94607373
Thanks a lot for submitting this. It is a cool feature - we'll need to
think about whether we like this charting library vs the one in the timeline
view PR. I am going to defer to @kayousterhout to give a more thorough review,
but I mentioned a few things inline.
I am a bit concerned about the scalability here. I tried a job locally with
1000 tasks and it took more than 10 seconds to generate the graph. It would be
good to explore what part takes a long time. I did some quick profiling and it
looks like getOffsetHeight in the dimple library was the culprit... that may be
tough to improve on.
Also, it might be nice to memoize the rendered graph in case someone opens
and closes the tab multiple times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
