Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28745931
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -21,6 +21,15 @@ import org.apache.spark.annotation.DeveloperApi
import org.apache.spark.rdd.RDD
import org.apache.spark.sql.catalyst.expressions._
+// for lazy computing, be sure the generator.terminate() called in the
very last
+private[execution] sealed case class LazyIterator(func: () =>
TraversableOnce[Row])
+ extends Iterator[Row] {
+
+ lazy val results = func().toIterator
+ override def hasNext: Boolean = results.hasNext
+ override def next(): Row = results.next()
+}
--- End diff --
@liancheng I just confirmed, the `CompletionIterator` provides a callback
machinism once finish iterating the iterator, however, all we need here is to
append an new iterator, which produced by the `terminate()` method.
But you're right, probably we need to update the `CompletionIterator` a
little bit, I leave a `TODO` here, and will file another PR for this
improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
