WamBamBoozle commented on a change in pull request #31072:
URL: https://github.com/apache/spark/pull/31072#discussion_r552954081



##########
File path: core/src/main/scala/org/apache/spark/internal/config/R.scala
##########
@@ -42,4 +42,16 @@ private[spark] object R {
     .version("1.5.3")
     .stringConf
     .createOptional
+
+  /** The SparkR daemon will evaluate this before forking. */
+  val R_DAEMON_INIT = ConfigBuilder("spark.r.daemonInit")
+    .version("3.2.0")
+    .stringConf
+    .createWithDefault("NULL")
+
+  /** milliseconds to wait until we give up launching the daemon */
+  val R_DAEMON_TIMEOUT = ConfigBuilder("spark.r.daemonTimeout")
+    .version("3.2.0")
+    .intConf
+    .createWithDefault(10000)

Review comment:
       Is the version indicated here reasonable? I don't understand the 
criteria for assigning version numbers really




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to