WamBamBoozle commented on pull request #31072: URL: https://github.com/apache/spark/pull/31072#issuecomment-756966434
Greetings @HyukjinKwon Thanks so much for your review! I'm looking at [python/test_coverage/coverage_daemon.py](https://github.com/apache/spark/pull/20204/files#diff-a19676926d6ad7cb2306c47aedc8c9dfd5bc4413ce1aaae8fb3b04c7c5836110) I agree that spark.python.daemon.module is more general and more powerful than what I am proposing. This PR is for fixing one thing, whereas what you did was a very general solution to a different problem. I don't want to warn my users that this is for advanced users only. The concept is simple: put your initialization code here. I propose we provide - spark.r.daemon.finalize - spark.r.daemon.initialize - spark.r.worker.finalize - spark.r.worker.initialize where the value of each of those are strings of R code that way we've achieved the same ends you have without forcing the user to understand the minutia of how and what to load. If you agree, I will change this PR to be the implementation of spark.r.daemon.initialize (instead of what it is now, spark.r.daemonInit). I would then open another ticket to implement the other flags. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
