vlsi commented on a change in pull request #31104:
URL: https://github.com/apache/spark/pull/31104#discussion_r554444888
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -89,6 +89,14 @@ jobs:
# In order to fetch changed files
with:
fetch-depth: 0
+ - uses: actions/checkout@v2
+ name: checkout n1hility/cancel-previous-runs
+ with:
+ repository: n1hility/cancel-previous-runs
+ path: ./build/.actions/n1hility/cancel-previous-runs
+ ref: 953c92201f368370112ea2754545cb4468d89f12 # v2
+ fetch-depth: 1
+ - uses: ./build/.actions/n1hility/cancel-previous-runs
Review comment:
Token is needed here:
https://github.com/apache/spark/pull/31104/checks?check_run_id=1673964946#step:4:15
See how the token was declared:
https://github.com/apache/spark/pull/31098/files#diff-48c0ee97c53013d18d6bbae44648f7fab9af2e0bf5b0dc1ca761e18ec5c478f2R94
Could you please add it to see if the action would be able to cancel your
previous runs for this PR?
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -89,6 +89,14 @@ jobs:
# In order to fetch changed files
with:
fetch-depth: 0
+ - uses: actions/checkout@v2
+ name: checkout n1hility/cancel-previous-runs
+ with:
+ repository: n1hility/cancel-previous-runs
+ path: ./build/.actions/n1hility/cancel-previous-runs
+ ref: 953c92201f368370112ea2754545cb4468d89f12 # v2
+ fetch-depth: 1
+ - uses: ./build/.actions/n1hility/cancel-previous-runs
Review comment:
Token is required for cancel-previous-runs:
https://github.com/n1hility/cancel-previous-runs/blob/178b93a12fb2731212e48c2cc5b7e37b937fd339/action.yml#L5-L7
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -89,6 +89,14 @@ jobs:
# In order to fetch changed files
with:
fetch-depth: 0
+ - uses: actions/checkout@v2
+ name: checkout n1hility/cancel-previous-runs
+ with:
+ repository: n1hility/cancel-previous-runs
+ path: ./build/.actions/n1hility/cancel-previous-runs
+ ref: 953c92201f368370112ea2754545cb4468d89f12 # v2
+ fetch-depth: 1
+ - uses: ./build/.actions/n1hility/cancel-previous-runs
Review comment:
@mik-laj, please double-check the link I highlight:
https://github.com/apache/spark/pull/31104/checks?check_run_id=1673964946#step:4:15
It literally says that `n1hility/cancel-previous-runs` fails and it requires
authentication:
```
Run ./build/.actions/n1hility/cancel-previous-runs
with:
env:
MODULES_TO_TEST: core, unsafe, kvstore, avro, network-common,
network-shuffle, repl, launcher, examples, sketch, graphx
EXCLUDED_TAGS:
INCLUDED_TAGS:
HADOOP_PROFILE: hadoop3.2
HIVE_PROFILE: hive2.3
CONDA_PREFIX: /usr/share/miniconda
GITHUB_PREV_SHA: 50d17ba02600601f8f63fcd55c2bf70865f9dc6e
GITHUB_INPUT_BRANCH:
[@octokit/rest] `const Octokit = require("@octokit/rest")` is deprecated.
Use `const { Octokit } = require("@octokit/rest")` instead
Branch is patch-1, repo is spark, and owner is apache, and id is 474259497
(node:1987) UnhandledPromiseRejectionWarning: Error: Parameter token or
opts.auth is required
at Function.getAuthString
(/home/runner/work/spark/spark/build/.actions/n1hility/cancel-previous-runs/dist/index.js:5899:19)
at Function.getOctokitOptions
(/home/runner/work/spark/spark/build/.actions/n1hility/cancel-previous-runs/dist/index.js:5864:29)
at new GitHub
(/home/runner/work/spark/spark/build/.actions/n1hility/cancel-previous-runs/dist/index.js:5848:22)
at
/home/runner/work/spark/spark/build/.actions/n1hility/cancel-previous-runs/dist/index.js:1492:25
at Generator.next (<anonymous>)
at
/home/runner/work/spark/spark/build/.actions/n1hility/cancel-previous-runs/dist/index.js:1448:71
at new Promise (<anonymous>)
at module.exports.131.__awaiter
(/home/runner/work/spark/spark/build/.actions/n1hility/cancel-previous-runs/dist/index.js:1444:12)
at cancelDuplicates
(/home/runner/work/spark/spark/build/.actions/n1hility/cancel-previous-runs/dist/index.js:1491:12)
at
/home/runner/work/spark/spark/build/.actions/n1hility/cancel-previous-runs/dist/index.js:1600:13
(node:1987) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
This error originated either by throwing inside of an async function without a
catch block, or by rejecting a promise which was not handled with .catch().
(rejection id: 1)
(node:1987) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections that are not handled will
terminate the Node.js process with a non-zero exit code.
```
Apparently, that does not look like a workable action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
