HyukjinKwon commented on a change in pull request #31104:
URL: https://github.com/apache/spark/pull/31104#discussion_r554497201
##########
File path: .github/workflows/build_and_test_workflow_run.yml
##########
@@ -0,0 +1,25 @@
+name: Cancelling Duplicates
+on:
+ workflow_run:
+ workflows:
+ - 'Build and test'
+ types: ['requested']
+
+jobs:
+ cancel-duplicate-workflow-runs:
+ name: "Cancel duplicate workflow runs"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ name: checkout potiuk/cancel-workflow-runs
+ with:
+ repository: potiuk/cancel-workflow-runs
+ path: ./build/.actions/potiuk/cancel-workflow-runs
+ ref: 953e057dc81d3458935a18d1184c386b0f6b5738 # @master
+ fetch-depth: 1
+ - uses: ./build/.actions/potiuk/cancel-workflow-runs
Review comment:
Seems we're working around the new Apache policy vs GitHub Actions to
use this plugin. Should we allow this via INFRA ticket? I have seen the
original repo was asked here
[INFRA-21287](https://issues.apache.org/jira/browse/INFRA-21287).
##########
File path: .github/workflows/build_and_test_workflow_run.yml
##########
@@ -0,0 +1,25 @@
+name: Cancelling Duplicates
+on:
+ workflow_run:
+ workflows:
+ - 'Build and test'
+ types: ['requested']
+
+jobs:
+ cancel-duplicate-workflow-runs:
+ name: "Cancel duplicate workflow runs"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ name: checkout potiuk/cancel-workflow-runs
+ with:
+ repository: potiuk/cancel-workflow-runs
+ path: ./build/.actions/potiuk/cancel-workflow-runs
+ ref: 953e057dc81d3458935a18d1184c386b0f6b5738 # @master
+ fetch-depth: 1
+ - uses: ./build/.actions/potiuk/cancel-workflow-runs
Review comment:
In that case, are we able to use it by explicit tag or hash via
`potiuk/cancel-workflow-runs@hash`, instead of manually fetching the repository?
##########
File path: .github/workflows/build_and_test_workflow_run.yml
##########
@@ -0,0 +1,25 @@
+name: Cancelling Duplicates
+on:
+ workflow_run:
+ workflows:
+ - 'Build and test'
+ types: ['requested']
+
+jobs:
+ cancel-duplicate-workflow-runs:
+ name: "Cancel duplicate workflow runs"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ name: checkout potiuk/cancel-workflow-runs
+ with:
+ repository: potiuk/cancel-workflow-runs
+ path: ./build/.actions/potiuk/cancel-workflow-runs
+ ref: 953e057dc81d3458935a18d1184c386b0f6b5738 # @master
+ fetch-depth: 1
+ - uses: ./build/.actions/potiuk/cancel-workflow-runs
Review comment:
Thanks for clarification, @mik-laj.
I think maybe it's a better approach to just allow this plugin by the
standard approach via filing an INFRA ticket and allowing it if this fork will
be maintained by syncing with the upstream because the newer changes will
likely be reviewed properly as it seems like the fork owner @potiuk is a
committer and PMC in Apache Airflow.
If we plan to make a PR to allow the diff in the original repo
(https://github.com/n1hility/cancel-previous-runs), the temporary workaround
might be fine but we will have to make sure either allowing
`n1hility/cancel-previous-runs` or `potiuk/cancel-workflow-runs` in the end.
##########
File path: .github/workflows/build_and_test_workflow_run.yml
##########
@@ -0,0 +1,25 @@
+name: Cancelling Duplicates
+on:
+ workflow_run:
+ workflows:
+ - 'Build and test'
+ types: ['requested']
+
+jobs:
+ cancel-duplicate-workflow-runs:
+ name: "Cancel duplicate workflow runs"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ name: checkout potiuk/cancel-workflow-runs
+ with:
+ repository: potiuk/cancel-workflow-runs
+ path: ./build/.actions/potiuk/cancel-workflow-runs
+ ref: 953e057dc81d3458935a18d1184c386b0f6b5738 # @master
+ fetch-depth: 1
+ - uses: ./build/.actions/potiuk/cancel-workflow-runs
Review comment:
Awesome!
##########
File path: .github/workflows/build_and_test_workflow_run.yml
##########
@@ -0,0 +1,18 @@
+name: Cancelling Duplicates
+on:
+ workflow_run:
+ workflows:
+ - 'Build and test'
+ types: ['requested']
+
+jobs:
+ cancel-duplicate-workflow-runs:
+ name: "Cancel duplicate workflow runs"
+ runs-on: ubuntu-latest
+ steps:
+ - uses:
potiuk/cancel-workflow-runs@953e057dc81d3458935a18d1184c386b0f6b5738
Review comment:
If this is supposed to be maintained separately, we can even switch this
to the proper release or using `master` branch since @potiuk seems a ASF
committer / PMC in Airflow. However, using hash seems okay too for now.
##########
File path: .github/workflows/build_and_test_workflow_run.yml
##########
@@ -0,0 +1,18 @@
+name: Cancelling Duplicates
+on:
+ workflow_run:
+ workflows:
+ - 'Build and test'
+ types: ['requested']
+
+jobs:
+ cancel-duplicate-workflow-runs:
+ name: "Cancel duplicate workflow runs"
+ runs-on: ubuntu-latest
+ steps:
+ - uses:
potiuk/cancel-workflow-runs@953e057dc81d3458935a18d1184c386b0f6b5738
Review comment:
If this is supposed to be maintained separately, we can even switch this
to the proper release or using `master` branch since @potiuk seems a ASF
committer / PMC in Airflow - all newer changes will likely be reviewed
properly. However, using hash seems okay too for now.
##########
File path: .github/workflows/build_and_test_workflow_run.yml
##########
@@ -0,0 +1,18 @@
+name: Cancelling Duplicates
+on:
+ workflow_run:
+ workflows:
+ - 'Build and test'
+ types: ['requested']
+
+jobs:
+ cancel-duplicate-workflow-runs:
+ name: "Cancel duplicate workflow runs"
+ runs-on: ubuntu-latest
+ steps:
+ - uses:
potiuk/cancel-workflow-runs@953e057dc81d3458935a18d1184c386b0f6b5738
Review comment:
👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
