jaceklaskowski commented on a change in pull request #31053:
URL: https://github.com/apache/spark/pull/31053#discussion_r556507111
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -171,6 +171,18 @@ private[sql] class SharedState(
object SharedState extends Logging {
@volatile private var fsUrlStreamHandlerFactoryInitialized = false
+ private var sharedState: SharedState = _
+
+ def getSharedState(
Review comment:
Just curious: why not `get` alone?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -171,6 +171,18 @@ private[sql] class SharedState(
object SharedState extends Logging {
@volatile private var fsUrlStreamHandlerFactoryInitialized = false
+ private var sharedState: SharedState = _
+
+ def getSharedState(
+ sparkContext: SparkContext,
+ initialConfigs: scala.collection.Map[String, String])
+ : SharedState = synchronized {
Review comment:
nit: could you merge the line (return type) with the line above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
