vinooganesh commented on a change in pull request #31053:
URL: https://github.com/apache/spark/pull/31053#discussion_r556561951
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -171,6 +171,18 @@ private[sql] class SharedState(
object SharedState extends Logging {
@volatile private var fsUrlStreamHandlerFactoryInitialized = false
+ private var sharedState: SharedState = _
Review comment:
also nit: I think this variable name should be prefixed with `_` as in
`_sharedState`. that would make it consistent with how other classes handle
internal state:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkContext.scala#L202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
