Github user scwf commented on the pull request:

    https://github.com/apache/spark/pull/5612#issuecomment-94998467
  
    @chenghao-intel , For this case i do not think we should add a `condition` 
field to concrete leftsemi join physical node. This is because the condition is 
a  join predicate(such as `x.a >= y.a + 2`),  we can not use leftsemijoin, 
should use hash join instead. 
    
    But when the condition is not a  join predicate (such as `x.a >= 1 and  y.a 
+ 2 < 3`), we can add a `condition` field to do the filter in leftsemi join, i 
think this is a optimization.
    
    This PR focus on the issue for condition is a  join predicate. 
    
    For the condition is not join predicate, i am writring a new PR.
    
    /cc @marmbrus any more comments?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to