peter-toth commented on a change in pull request #29737:
URL: https://github.com/apache/spark/pull/29737#discussion_r556818252
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -160,6 +160,9 @@ class OrcFileFormat
val capacity = sqlConf.orcVectorizedReaderBatchSize
OrcConf.IS_SCHEMA_EVOLUTION_CASE_SENSITIVE.setBoolean(hadoopConf,
sqlConf.caseSensitiveAnalysis)
+ OrcConf.FORCE_POSITIONAL_EVOLUTION.setBoolean(hadoopConf,
+ hadoopConf.getBoolean("spark.hadoop." +
OrcConf.FORCE_POSITIONAL_EVOLUTION.getAttribute,
+ false))
Review comment:
Hmm, I might get something wrong but I don't think that `hadoopConf` is
cleaned here as if I remove this line the UTs fail. As far as I see the only
reference to `SparkHadoopUtil.appendSparkHadoopConfigs` is from`spark-hive`
[HiveUtils.newTemporaryConfiguration](https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala#L547).
I can revert the prefix in
https://github.com/apache/spark/pull/29737/files#diff-e14fd8725cf71eee7b34fa299c2f3abe5a0033f9abce9de4c7e081ba57991b0bR146
though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
