dongjoon-hyun commented on a change in pull request #29737:
URL: https://github.com/apache/spark/pull/29737#discussion_r556839642
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -160,6 +160,9 @@ class OrcFileFormat
val capacity = sqlConf.orcVectorizedReaderBatchSize
OrcConf.IS_SCHEMA_EVOLUTION_CASE_SENSITIVE.setBoolean(hadoopConf,
sqlConf.caseSensitiveAnalysis)
+ OrcConf.FORCE_POSITIONAL_EVOLUTION.setBoolean(hadoopConf,
+ hadoopConf.getBoolean("spark.hadoop." +
OrcConf.FORCE_POSITIONAL_EVOLUTION.getAttribute,
+ false))
Review comment:
Parquet is the same. Please see `ParquetFileFormat.scala`. In this
context, the Hadoop Conf should have the original conf key, not `spark.hadoop`
prefixed ones.
```
lazy val footerFileMetaData =
ParquetFileReader.readFooter(sharedConf, filePath,
SKIP_ROW_GROUPS).getFileMetaData
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
