MaxGekk commented on a change in pull request #31172:
URL: https://github.com/apache/spark/pull/31172#discussion_r556869572



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -162,7 +160,7 @@ class DataSourceV2Strategy(session: SparkSession) extends 
Strategy with Predicat
       }
 
     case RefreshTable(r: ResolvedTable) =>
-      RefreshTableExec(r.catalog, r.identifier, invalidateCache(r, 
recacheTable = true)) :: Nil

Review comment:
       Also, I think we should apply the approach proposed in this PR to 
`CatalogImpl.refreshTable()`:
   
https://github.com/apache/spark/blob/62d82b5b270c2eea27ba026e66b7d6598bbaa0a6/sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala#L538-L558
   
   Current implementation is expensive in terms of Hive catalog calls and files 
listen. For example, when I started calling the function, it lead to additional 
ops in https://github.com/apache/spark/pull/31066#discussion_r556497006




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to