MaxGekk commented on a change in pull request #31172:
URL: https://github.com/apache/spark/pull/31172#discussion_r556893966
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -1629,16 +1629,23 @@ class DataSourceV2SQLSuite
}
}
- test("SPARK-33435: REFRESH TABLE should invalidate all caches referencing
the table") {
+ test("SPARK-33435, SPARK-34099: REFRESH TABLE should refresh all caches
referencing the table") {
val tblName = "testcat.ns.t"
withTable(tblName) {
withTempView("t") {
sql(s"CREATE TABLE $tblName (id bigint) USING foo")
+ sql(s"INSERT INTO $tblName SELECT 0")
sql(s"CACHE TABLE t AS SELECT id FROM $tblName")
+ checkAnswer(spark.table(tblName), Row(0))
+ checkAnswer(spark.table("t"), Row(0))
+
+ sql(s"INSERT INTO $tblName SELECT 1")
assert(spark.sharedState.cacheManager.lookupCachedData(spark.table("t")).isDefined)
sql(s"REFRESH TABLE $tblName")
-
assert(spark.sharedState.cacheManager.lookupCachedData(spark.table("t")).isEmpty)
+
assert(spark.sharedState.cacheManager.lookupCachedData(spark.table("t")).isDefined)
Review comment:
> REFRESH TABLE still recaches the table itself right?
Right.
> and uncaches all dependencies is just conservative but not incorrect?
Correct, in term of correctness, this is not a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
