Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/5617#discussion_r28842177
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -61,7 +61,16 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
var pyFiles: String = null
var isR: Boolean = false
var action: SparkSubmitAction = null
- val sparkProperties: HashMap[String, String] = new HashMap[String,
String]()
+ val sparkProperties: HashMap[String, String] = new HashMap[String,
String]() {
+ override def put(k: String, v: String): Option[String] = {
--- End diff --
Agree with Sean. The behavior you're introducing that always ignores
non-spark properties seems right to me, but extending HashMap here seems a
little weird.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
