Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5617#discussion_r28860589
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -77,12 +77,8 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
if (verbose) SparkSubmit.printStream.println(s"Using properties file:
$propertiesFile")
Option(propertiesFile).foreach { filename =>
Utils.getPropertiesFromFile(filename).foreach { case (k, v) =>
- if (k.startsWith("spark.")) {
--- End diff --
Do you need this logic in two places if the props are later removed? Maybe
there's a reason, just checking if it can be avoided. This looks better to me.
@sryza will know the logic better than I.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
