srowen commented on a change in pull request #31191:
URL: https://github.com/apache/spark/pull/31191#discussion_r558935353
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
##########
@@ -165,17 +169,41 @@ $(document).ready(function() {
var completedColumnName = 'completed';
var durationColumnName = 'duration';
var conf = {
+ "data": array,
"columns": [
- {name: 'version'},
- {name: 'appId', type: "appid-numeric"},
- {name: 'appName'},
- {name: attemptIdColumnName},
- {name: startedColumnName},
- {name: completedColumnName},
- {name: durationColumnName, type: "title-numeric"},
- {name: 'user'},
- {name: 'lastUpdated'},
- {name: 'eventLog'},
+ {name: 'version', data: 'version' },
+ {
+ name: 'appId',
+ type: "appid-numeric",
+ data: 'id',
+ render: (id, type, row) => `<span title="${id}"><a
href="${row.attemptUrl}">${id}</a></span>`
+ },
+ {name: 'appName', data: 'name' },
+ {
+ name: attemptIdColumnName,
+ data: 'attemptId',
+ render: (attemptId, type, row) => (attemptId ? `<a
href="${row.attemptUrl}">${attemptId}</a>` : '')
+ },
+ {name: startedColumnName, data: 'startTime' },
+ {name: completedColumnName, data: 'endTime' },
+ {name: durationColumnName, type: "title-numeric", data: 'duration'
},
+ {name: 'user', data: 'sparkUser' },
+ {name: 'lastUpdated', data: 'lastUpdated' },
+ {
+ name: 'eventLog',
+ data: 'log',
+ render: (log, type, row) => `<a href="${log}" class="btn
btn-info btn-mini">Download</a>`
+ },
+ ],
+ "aoColumnDefs": [
Review comment:
OK I see. Does the table look the exact same before and after - there's
no visual change? if so I don't think we need screenshots.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
