[GitHub] [spark] mohan3d commented on a change in pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading

Sat, 16 Jan 2021 08:02:49 -0800 


mohan3d commented on a change in pull request #31191:
URL: https://github.com/apache/spark/pull/31191#discussion_r558941444



##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
##########
@@ -165,17 +169,41 @@ $(document).ready(function() {
         var completedColumnName = 'completed';
         var durationColumnName = 'duration';
         var conf = {
+          "data": array,
           "columns": [
-            {name: 'version'},
-            {name: 'appId', type: "appid-numeric"},
-            {name: 'appName'},
-            {name: attemptIdColumnName},
-            {name: startedColumnName},
-            {name: completedColumnName},
-            {name: durationColumnName, type: "title-numeric"},
-            {name: 'user'},
-            {name: 'lastUpdated'},
-            {name: 'eventLog'},
+            {name: 'version', data: 'version' },
+            {
+              name: 'appId', 
+              type: "appid-numeric", 
+              data: 'id',
+              render:  (id, type, row) => `<span title="${id}"><a 
href="${row.attemptUrl}">${id}</a></span>`
+            },
+            {name: 'appName', data: 'name' },
+            {
+              name: attemptIdColumnName, 
+              data: 'attemptId',
+              render: (attemptId, type, row) => (attemptId ? `<a 
href="${row.attemptUrl}">${attemptId}</a>` : '')
+            },
+            {name: startedColumnName, data: 'startTime' },
+            {name: completedColumnName, data: 'endTime' },
+            {name: durationColumnName, type: "title-numeric", data: 'duration' 
},
+            {name: 'user', data: 'sparkUser' },
+            {name: 'lastUpdated', data: 'lastUpdated' },
+            {
+              name: 'eventLog', 
+              data: 'log', 
+              render: (log, type, row) => `<a href="${log}" class="btn 
btn-info btn-mini">Download</a>` 
+            },
+          ],
+          "aoColumnDefs": [

Review comment:
       Before
   <img width="1771" alt="dev" 
src="https://user-images.githubusercontent.com/14618484/104816576-1739e000-5857-11eb-8f39-a2bb9d5a4085.png";>
   
   After
   <img width="1763" alt="prod" 
src="https://user-images.githubusercontent.com/14618484/104816581-1acd6700-5857-11eb-8062-d35551d609f4.png";>
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to