cloud-fan commented on a change in pull request #31253:
URL: https://github.com/apache/spark/pull/31253#discussion_r561049706
##########
File path: sql/core/benchmarks/CharVarcharBenchmark-results.txt
##########
@@ -6,85 +6,130 @@ Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X
10.16
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Read with length 20, hasSpaces: false: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-read string with length 20 1504 1508
4 66.5 15.0 1.0X
-read char with length 20 1680 1684
3 59.5 16.8 0.9X
-read varchar with length 20 1659 1682
26 60.3 16.6 0.9X
+read string with length 20 1605 1636
39 62.3 16.1 1.0X
+read char with length 20 1731 1740
12 57.8 17.3 0.9X
+read varchar with length 20 1716 1729
15 58.3 17.2 0.9X
Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Read with length 40, hasSpaces: false: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-read string with length 40 1662 1678
15 60.2 16.6 1.0X
-read char with length 40 1721 1731
9 58.1 17.2 1.0X
-read varchar with length 40 1694 1706
12 59.0 16.9 1.0X
+read string with length 40 1712 1716
5 58.4 17.1 1.0X
+read char with length 40 1660 1686
41 60.2 16.6 1.0X
+read varchar with length 40 1670 1721
46 59.9 16.7 1.0X
Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Read with length 60, hasSpaces: false: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-read string with length 60 1623 1643
23 61.6 16.2 1.0X
-read char with length 60 1644 1685
66 60.8 16.4 1.0X
-read varchar with length 60 1660 1680
18 60.2 16.6 1.0X
+read string with length 60 1708 1720
15 58.6 17.1 1.0X
+read char with length 60 1652 1677
29 60.5 16.5 1.0X
+read varchar with length 60 1649 1675
22 60.6 16.5 1.0X
Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Read with length 80, hasSpaces: true: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-read string with length 80 1629 1678
57 61.4 16.3 1.0X
-read char with length 80 1630 1667
65 61.3 16.3 1.0X
-read varchar with length 80 1664 1684
34 60.1 16.6 1.0X
+read string with length 80 1720 1726
6 58.1 17.2 1.0X
+read char with length 80 1650 1670
33 60.6 16.5 1.0X
+read varchar with length 80 1653 1667
21 60.5 16.5 1.0X
Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Read with length 100, hasSpaces: true: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-read string with length 100 1594 1612
17 62.7 15.9 1.0X
-read char with length 100 1631 1642
11 61.3 16.3 1.0X
-read varchar with length 100 1635 1644
13 61.1 16.4 1.0X
+read string with length 100 1699 1703
5 58.8 17.0 1.0X
+read char with length 100 1660 1677
15 60.2 16.6 1.0X
+read varchar with length 100 1654 1658
3 60.4 16.5 1.0X
================================================================================================
-Char Varchar Write Side Perf
+Char Varchar Write Side Perf w/o Tailing Spaces
================================================================================================
Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Write with length 20, hasSpaces: false: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-write string with length 20 2760 2784
21 3.6 276.0 1.0X
-write char with length 20 2898 2917
22 3.5 289.8 1.0X
-write varchar with length 20 2876 2892
14 3.5 287.6 1.0X
+write string with length 20 2322 2334
12 4.3 232.2 1.0X
+write char with length 20 2490 2498
7 4.0 249.0 0.9X
+write varchar with length 20 2481 2494
16 4.0 248.1 0.9X
Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Write with length 40, hasSpaces: false: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-write string with length 40 2726 2734
9 3.7 272.6 1.0X
-write char with length 40 2885 2898
16 3.5 288.5 0.9X
-write varchar with length 40 2844 2860
15 3.5 284.4 1.0X
+write string with length 40 2302 2316
13 4.3 230.2 1.0X
+write char with length 40 2464 2488
24 4.1 246.4 0.9X
+write varchar with length 40 2471 2481
14 4.0 247.1 0.9X
Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Write with length 60, hasSpaces: false: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-write string with length 60 2724 2739
21 3.7 272.4 1.0X
-write char with length 60 2868 2912
44 3.5 286.8 0.9X
-write varchar with length 60 2870 2896
23 3.5 287.0 0.9X
+write string with length 60 2329 2341
11 4.3 232.9 1.0X
+write char with length 60 2483 2510
26 4.0 248.3 0.9X
+write varchar with length 60 2449 2470
19 4.1 244.9 1.0X
+
+Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16
+Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
+Write with length 80, hasSpaces: false: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
+------------------------------------------------------------------------------------------------------------------------
+write string with length 80 2293 2310
24 4.4 229.3 1.0X
+write char with length 80 2483 2504
37 4.0 248.3 0.9X
+write varchar with length 80 2469 2480
12 4.1 246.9 0.9X
+
+Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16
+Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
+Write with length 100, hasSpaces: false: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
+------------------------------------------------------------------------------------------------------------------------
+write string with length 100 2310 2327
16 4.3 231.0 1.0X
+write char with length 100 2476 2515
35 4.0 247.6 0.9X
+write varchar with length 100 2466 2486
23 4.1 246.6 0.9X
+
+
+================================================================================================
+Char Varchar Write Side Perf w Tailing Spaces
+================================================================================================
+
+Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16
+Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
+Write with length 20, hasSpaces: true: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
Review comment:
I think we don't need to print `hasSpaces: true` now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
