cloud-fan commented on a change in pull request #31253:
URL: https://github.com/apache/spark/pull/31253#discussion_r561049938
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CharVarcharBenchmark.scala
##########
@@ -112,9 +112,16 @@ object CharVarcharBenchmark extends SqlBasedBenchmark {
}
}
- runBenchmark("Char Varchar Write Side Perf") {
+ runBenchmark("Char Varchar Write Side Perf w/o Tailing Spaces") {
for (len <- range) {
- writeBenchmark(N / 10, len, len >= 80)
+ writeBenchmark(N / 10, len, hasSpaces = false)
+ }
+ }
+
+ runBenchmark("Char Varchar Write Side Perf w Tailing Spaces") {
Review comment:
can we do the same for the read benchmark?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
