saikocat edited a comment on pull request #31262: URL: https://github.com/apache/spark/pull/31262#issuecomment-764194680
Just for discussion, I think updating the API like solve the chicken and egg problems with putting and getting stuffs in the metadata builder in the pull request (31252). Though, I am not sure why don't we: 1. Create a case class (JdbcMetadata(sqlType, dataType, scale...) so the API of JdbcDialect won't be changed so frequent in case we want to add in additional field parameter like in this PR. 2. Or just pass in the ResultSetMetadata - this break abstraction & introduce dependencies though Cheers, ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
