sarutak commented on a change in pull request #31262:
URL: https://github.com/apache/spark/pull/31262#discussion_r561562053



##########
File path: 
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
##########
@@ -181,7 +181,7 @@ class PostgresIntegrationSuite extends 
DockerJDBCIntegrationSuite {
     val rows = dfRead.collect()
     val types = rows(0).toSeq.map(x => x.getClass.toString)
     assert(types(1).equals("class java.sql.Timestamp"))
-    assert(types(2).equals("class java.sql.Timestamp"))
+    assert(types(2).equals("class java.lang.Integer"))

Review comment:
       That PR (#30902) has two problems.
   1. Regression which affects PostgresDialect.
   2. `jdbc.*IntegrationSuite` doesn't reflect the change (`jdbc.Types.TIME` to 
`sql.types.IntegerType` mapping).
   
   Even though the problematic PR is the same (#30902), the root cause is 
different. So I'll forcus the problem-1 in this PR and open another PR to fix 
`jdbc.*IntegrationSuite`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to