Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5432#discussion_r28918841
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulerBackend.scala ---
@@ -41,4 +41,11 @@ private[spark] trait SchedulerBackend {
*/
def applicationId(): String = appId
+ /**
+ * Get an application ID associated with the job.
+ *
+ * @return An application attempt id
+ */
+ def applicationAttemptId(): String = ""
--- End diff --
I think it would be cleaner if you used an `Option[String]` with a default
of `None`. As I was reading the rest of the code I was wondering if every
framework would be forced to provide some dummy attempt id, or if would be
null, etc. `Option` would make that more explicit. Plus it seems you use an
option later in the listener event for json in any case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
