Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5432#discussion_r28919320
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/SchedulerBackend.scala ---
    @@ -41,4 +41,11 @@ private[spark] trait SchedulerBackend {
        */
       def applicationId(): String = appId
     
    +  /**
    +   * Get an application ID associated with the job.
    +   *
    +   * @return An application attempt id
    +   */
    +  def applicationAttemptId(): String = ""
    --- End diff --
    
    Yeah, I went back and forth on this bug forgot to revisit the code. I agree 
that `Option` would be better here, let me see how big a change that would be.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to