Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/615#discussion_r12222831
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
---
@@ -83,7 +83,8 @@ private[spark] class Worker(
@volatile var registered = false
@volatile var connected = false
val workerId = generateWorkerId()
- val sparkHome = new
File(Option(System.getenv("SPARK_HOME")).getOrElse("."))
+ val sparkHome = new File(conf.getOption("spark.home").orElse(Option(
--- End diff --
Since spark provide sparkconf to manage it's config system, we should first
get option from sparkconf, then system env(compatible with old version). And
weâd better avoid using system env.
Actually in sparkcontext it get sparkhome like this
private[spark] def getSparkHome(): Option[String] = {
conf.getOption("spark.home").orElse(Option(System.getenv("SPARK_HOME")))
}
also, we keep consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
