Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/615#discussion_r12223079
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala 
---
    @@ -83,7 +83,8 @@ private[spark] class Worker(
       @volatile var registered = false
       @volatile var connected = false
       val workerId = generateWorkerId()
    -  val sparkHome = new 
File(Option(System.getenv("SPARK_HOME")).getOrElse("."))
    +  val sparkHome = new File(conf.getOption("spark.home").orElse(Option(
    --- End diff --
    
    SparkConf is intended for application-wide configurations. SPARK_HOME is 
actually a node-dependent configuration, so we'd prefer to keep it outside of 
Spark conf. If you look we've done this for other node-specific configs like 
SPARK_LOCAL_DIR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to