cloud-fan commented on a change in pull request #31258:
URL: https://github.com/apache/spark/pull/31258#discussion_r569573336



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -259,8 +268,14 @@ abstract class DynamicPartitionPruningSuiteBase
           |SELECT f.date_id, f.store_id FROM fact_sk f
           |JOIN dim_store s ON f.store_id = s.store_id AND s.country = 'NL'
         """.stripMargin)
-
-      checkPartitionPruningPredicate(df, true, false)
+      if (adaptiveExecutionOn) {
+        // When enabling both AQE and DPP, PlanAdaptiveDynamicPruningFilters 
rule will insert
+        // the DPP filters only when the reused broadcast exchange exists. 
Otherwise it will

Review comment:
       Seems most of the test changes are caused by the same reason, and we can 
use `DisableAdaptiveExecution`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to