cloud-fan commented on a change in pull request #31258:
URL: https://github.com/apache/spark/pull/31258#discussion_r570004044
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/QueryStageExec.scala
##########
@@ -149,7 +149,8 @@ abstract class QueryStageExec extends LeafExecNode {
*/
Review comment:
Let's add parameter doc
```
/**
* ...
* @param id the query stage id.
* @param plan the underlying plan.
* @param _canonicalized the canonicalized plan before applying query stage
optimizer rules.
*/
```
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/QueryStageExec.scala
##########
@@ -197,7 +199,8 @@ case class ShuffleQueryStageExec(
*/
case class BroadcastQueryStageExec(
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
