Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5672#discussion_r29074591
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -148,7 +148,11 @@ private[spark] class DiskBlockManager(blockManager:
BlockManager, conf: SparkCon
/** Cleanup local dirs and stop shuffle sender. */
private[spark] def stop() {
// Remove the shutdown hook. It causes memory leaks if we leave it
around.
- Utils.removeShutdownHook(shutdownHook)
+ try {
+ Utils.removeShutdownHook(shutdownHook)
--- End diff --
What would it do instead? Just ignore the call and return `false`?
Probably not a big deal in practice, but it does overload the return value
to mean "either the hook doesn't exist, or I can't remove it at this time".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
