Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5672#issuecomment-96080347
In general I'd argue for not just catching exceptions broadly as a defense.
This is a `stop()` method though, and often the right behavior is to just keep
going even if stopping failed due to some I/O problem or messed up state. Here
I don't see what exception this method can throw. I'd still find `try-catch`
surprising and would not expect it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]