srowen commented on pull request #31541: URL: https://github.com/apache/spark/pull/31541#issuecomment-777435264
FWIW I wouldn't argue too much about process here. We all know the deal, we all use good judgment and don't have to send around reminders about the importance of reviews. I also find I can't for love or money get someone else to look at a PR and judge it's OK to go ahead. The original PR was open a long time and had at least a late LGTM. One unfortunate truth is that things sometimes get reviewed _after_ they're committed and get built, used by downstream consumers. Now we do have some legit concerns about the change it seems, here and in the original PR. I'd say give a fair shot at fixing forward / addressing concerns? If there are still valid outstanding concerns, then it seems reasonable to revert and take it back to the drawing boards. But then I'd say, please engage about resolving the original issue actively, if there is any possible way to satisfy everyone's concerns. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
