aokolnychyi commented on pull request #31580: URL: https://github.com/apache/spark/pull/31580#issuecomment-780905875
@HeartSaVioR, this change is self-contained. At least, I don't have a PR that depends on it. I think I overlooked this part when I introduced this class. As far as I know, the SQL standard does not define the default null ordering for a sort direction. That's why the default value is different among query engines. Since this class is part of our public expression API, I am afraid to let data sources to interpret this. That's why I tried to match the behavior in Catalyst `SortDirection`, which also exposes this method. But it is just a safety measure, there is no requirement to do it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
