HeartSaVioR commented on a change in pull request #31580:
URL: https://github.com/apache/spark/pull/31580#discussion_r578004932
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/SortDirection.java
##########
@@ -19,14 +19,33 @@
import org.apache.spark.annotation.Experimental;
+import static
org.apache.spark.sql.connector.expressions.NullOrdering.NULLS_FIRST;
+import static
org.apache.spark.sql.connector.expressions.NullOrdering.NULLS_LAST;
+
/**
* A sort direction used in sorting expressions.
+ * <p>
+ * Each direction has a default null ordering that is implied if no null
ordering is specified
Review comment:
This is confusing me as someone could specify the null ordering
explicitly but in reality we don't leverage the default null ordering in any
way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
