HeartSaVioR edited a comment on pull request #31580: URL: https://github.com/apache/spark/pull/31580#issuecomment-780922631
So I basically understand what this PR is trying to do and I'm appreciated about the details. Nice! I'd just like to check what more approaches we can do to clarify the default null ordering to data source developers easier to indicate. Do we expect them to look into the code directly, or expect them to call `defaultNullOrdering()` before using it, or just rely on javadoc? If we suppose the data source developers are lazy and just want to look javadoc at most, is the new addition exposed to the javadoc? (It's just to confirm, I don't know the answer unless creating javadoc.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
