Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5697#discussion_r29103607
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala 
---
    @@ -77,6 +77,11 @@ sealed trait Vector extends Serializable {
             // refer to {@link java.util.Arrays.equals} for hash algorithm
             val bits = java.lang.Double.doubleToLongBits(value)
             result = 31 * result + (bits ^ (bits >>> 32)).toInt
    +        i += 1
    +        // only scan the first 16 nonzeros
    +        if (i > 16) {
    +          return result
    --- End diff --
    
    `foreachActive` is usually on the critical path. This hashCode 
implementation is only for the cases when the vector is used as a map key, as 
in the Pyrolite SerDe. I added specialized version for DenseVector and 
SparseVector.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to